[ML] Fix UI Actions context menu positioning for the Anomaly Swim Lane #71839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
bug
|
Pinging @elastic/ml-ui (:ml) |
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jul 15, 2020
elastic#71839) * [ML] fix swim lane embeddable rerenders * [ML] fix TS
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 15, 2020
* master: [Form lib] Memoize form hook object and fix hook array deps (elastic#71237) [uiActions] Support emitting nested triggers and actions (elastic#70602) add short sleep before clicking Remove on sample data (elastic#71104) Fixed the beta badge layout. (elastic#71835) Restores task for downloading Chromium builds (elastic#71749) [logging] Format new platform json logging to ECS (elastic#71138) add policy details and update SO limit requests (elastic#71789) Convert vis_type_vega to Typescript (elastic#68915) [ML] Fix UI Actions context menu positioning for the Anomaly Swim Lane (elastic#71839)
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jul 16, 2020
elastic#71839) * [ML] fix swim lane embeddable rerenders * [ML] fix TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#70705 has changed the logic of positioning the UI context menu, it relies on the element that has received a click event originally. But the anomaly swim lane was completely rerendered on cell selection, which caused unmounting the original element that received the click from the DOM tree. I've tried to resolve it with minimum changes by caching selection in the component state and checking it with
shouldComponentUpdatelifecycle hook.Please bear in mind on the Anomaly Explorer page the swim lane still rerenders on the selection change, it happens because of the way state works.
Checklist